fix(file response): Support varying mtime semantics across different fsspec implementations
#3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3902 +/- ##
=======================================
Coverage 98.34% 98.35%
=======================================
Files 345 345
Lines 15589 15605 +16
Branches 1720 1725 +5
=======================================
+ Hits 15331 15348 +17
+ Misses 124 122 -2
- Partials 134 135 +1 ☔ View full report in Codecov by Sentry. |
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3902 |
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the implementation of
responses.Fileto be able to handle most fsspec implementation'smtimeequivalent.This is necessary because fsspec implementations do not have a standardised way to retrieve an
mtimeequivalent; Some report anmtime, while some may use a different key (e.g.Last-Modified) and others do not report this value at all.Fixes #3899